can config es id's constituent part #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it looks that you have already support for multiple Primary key, but forget remove the code.
…icsearch Conflicts: river/river.go
siddontang
reviewed
Apr 12, 2017
river/rule.go
Outdated
| @@ -13,6 +13,7 @@ type Rule struct { | |||
| Index string `toml:"index"` | |||
| Type string `toml:"type"` | |||
| Parent string `toml:"parent"` | |||
| Id []string `toml:"id"` | |||
siddontang
reviewed
Apr 12, 2017
river/sync.go
Outdated
| pks, err := canal.GetPKValues(rule.TableInfo, row) | ||
| if err != nil { | ||
| return "", err | ||
| var id []interface{} |
There was a problem hiding this comment.
var (
ids []interface{}
err error
)
|
Please add test for this feature. |
|
I have changed Id to ID, and add test, but can't pass the check. |
siddontang
approved these changes
Apr 12, 2017
siddontang
reviewed
Apr 12, 2017
etc/river.toml
Outdated
| @@ -58,6 +58,8 @@ schema = "test" | |||
| table = "t" | |||
| index = "test" | |||
| type = "t" | |||
| # Default will use the mysql's primary key as es's id, if set id will use the id's column value as id | |||
| id = ["id", "tags"] | |||
There was a problem hiding this comment.
please use another rule section for this feature.
Btw, please add this to ReadMe too.
|
Rest LGTM |
|
CI failed, please fix it. |
|
ok |
|
I have already modify the readme and example config file, and ci check passed |
siddontang
reviewed
Apr 13, 2017
| @@ -53,6 +53,16 @@ func GetPKValues(table *schema.Table, row []interface{}) ([]interface{}, error) | |||
| return values, nil | |||
| } | |||
|
|
|||
| // Get term column's value | |||
| func GetColumnValue(table *schema.Table, column string, row []interface{}) (interface{}, error) { | |||
There was a problem hiding this comment.
please update go-mysql commit version in glide.yml
|
done |
|
Thanks @WangXiangUSTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default the es's id use mysql's PK value, and now can config the id's constituent part use mysql's other column.